D27595: Watch for language change events, and forward those to the QML engine

broulik added a comment. Is there no better way to do this? e.g. the KWin Rules KCM spends 20% of its startup time in "retranslate" :/ REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27595 To: vkrause, mart Cc: davidedmundson, broulik, rikmills, ngraham, apol,

D27595: Watch for language change events, and forward those to the QML engine

rikmills added a comment. In D27595#636640 , @vkrause wrote: > I haven't seen a backtrace for this, but from what I understood from the chat backlog this is triggering a QML bug (?) due to the re-evaluation of qsTr() with 5.12, rather than

D27595: Watch for language change events, and forward those to the QML engine

vkrause added subscribers: broulik, davidedmundson. vkrause added a comment. In D27595#636543 , @rikmills wrote: > git bisect also shows that this crashes the virtual desktop and regional settings KCM in Kubuntu 20.04 I haven't seen a

D27595: Watch for language change events, and forward those to the QML engine

rikmills added a comment. git bisect also shows that this crashes the virtual desktop and regional settings KCM in Kubuntu 20.04 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27595 To: vkrause, mart Cc: rikmills, ngraham, apol, plasma-devel, fbampaloukas, GB_2,

D27595: Watch for language change events, and forward those to the QML engine

vkrause added a comment. I can reproduce only if I set a valid translation catalog. Even more surprising since the affected dialog does not seem to contain any qsTr() translations. I don't think this patch is wrong as such, the layouting glitch is a bug elsewhere that we trigger by the

D27595: Watch for language change events, and forward those to the QML engine

ngraham added a comment. `git bisect` says this caused https://bugs.kde.org/show_bug.cgi?id=418447. F8148416: Spacing sometimes too high.mp4 Would be nice to fix that regression before it gets shipped with Frameworks 5.68. REPOSITORY R169

D27595: Watch for language change events, and forward those to the QML engine

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9b7cae898ed7: Watch for language change events, and forward those to the QML engine (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27595: Watch for language change events, and forward those to the QML engine

vkrause added a comment. In D27595#616544 , @apol wrote: > I'm fine with this being done here for convenience, but it feels like it's something that should be in QQmlEngine itself. Right, or at least in QQmlApplicationEngine. REPOSITORY

D27595: Watch for language change events, and forward those to the QML engine

apol added a comment. I'm fine with this being done here for convenience, but it feels like it's something that should be in QQmlEngine itself. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27595 To: vkrause Cc: apol, plasma-devel, fbampaloukas, GB_2, domson,

D27595: Watch for language change events, and forward those to the QML engine

vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This fixes a race condition on startup for the Kirigami translation catalog that happens as follows: - QML code triggers