romangg added a comment.
Do you have an example? Name the product. I know it should be easy
technically, but my question is if it makes sense.
A mode is a combination of resolution and refresh rate. So I could imagine
there are products that prefer higher refresh rate over resolution. Bu
broulik added a comment.
Projectors and VMs can be weird. We already have the concept of
`preferredMode`, so adding an asterisk should be easy.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D27674
To: broulik, romangg, #vdg
Cc: apol, plasma-devel, Orage, LeGast00n,
romangg added a comment.
Do you have an example in the wild where the "default resolution" should be
something else than the one with highest pixel count?
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D27674
To: broulik, romangg, #vdg
Cc: apol, plasma-devel, Orage,
apol added a comment.
Out of scope for the patch, but it should also show the default resolution of
the display. It's also important for choosing the right aspect ratio.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D27674
To: broulik, romangg, #vdg
Cc: apol, plasm
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:62042a990525: feat(kcm): show resolution aspect ratio
(authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D27674?vs=76454&id=76461#toc
REPOSITORY
R104 KScreen
CHANGES SINCE
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Nice tight implementation.
INLINE COMMENTS
> output_model.cpp:497
> +const QString text = i18nc("Width x height (aspect ratio)", "%1x%2
> (%3:%4)",
> +
broulik created this revision.
broulik added reviewers: romangg, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
With a special case to prefer common "16:10" over "8:5"
TEST PLAN
F8133072: Screenshot_202
