D27799: Use system color scheme from Kirigami instead of Plasma theme color

2020-03-03 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R116:c9b2684a49d3: Use system color scheme from Kirigami instead of Plasma theme color (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabric

D27799: Use system color scheme from Kirigami instead of Plasma theme color

2020-03-03 Thread Jan Grulich
jgrulich updated this revision to Diff 76830. jgrulich added a comment. Don't use deprecated color REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27799?vs=76824&id=76830 BRANCH bug-418416 REVISION DETAIL https://phabricator.kd

D27799: Use system color scheme from Kirigami instead of Plasma theme color

2020-03-03 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > main.qml:43 > focus: true > -color: theme.backgroundColor > +color: Kirigami.Theme.viewBackgroundColor > } viewBackgroundColor is deprecated `WARNING: viewBackgroundColor is deprecated, use backgroundColor with colorS

D27799: Use system color scheme from Kirigami instead of Plasma theme color

2020-03-03 Thread Jan Grulich
jgrulich added a comment. One thing I'm not sure about whether to use **viewBackgroundColor** or just **backgroundColor**, because I want the buttons to look like they are part of the view. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D277

D27799: Use system color scheme from Kirigami instead of Plasma theme color

2020-03-03 Thread Jan Grulich
jgrulich created this revision. jgrulich added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY BUG: 418416 REPOSITORY R116 Plasma Network Management Applet BRANCH bug-418416 REVISION