ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patch fixes several errors in the code:
- The property is named `font.minimumPixelSi
muesli added a comment.
Your patch indeed makes the date behave like in previous releases again!
However I noticed it's still not quite consistent in its behavior: when I start
plasmashell freshly, the date is a lot wider than after resizing it to roughly
the same width. I've added a new att
ngraham added a comment.
Yeah, I've noticed that too. I haven't been able to figure out how to improve
it. Where it decides to wrap is also not very deterministic.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28172
To: ngraham, #vdg, #plasma
Cc: muesli,
muesli added a comment.
While it's not completely consistent yet, it still's an improvement that
reverts the recent regression. As such, I'm tempted to say LGTM.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28172
To: ngraham, #vdg, #plasma
Cc: muesli, pl
cblack accepted this revision as: VDG, cblack.
cblack added a comment.
This revision is now accepted and ready to land.
Visually looks nice, but would wait on review from a more experienced Plasma
person since this looks like it could potentially be problematic and
indeterministic at a glance
davidedmundson accepted this revision.
davidedmundson added a comment.
You probably still want the elide.
We have a word wrap on, so you'll only hit this elide option when the
alternative is paint outside the area and just leak over other items in the
system tray. That always looks rubbi
ngraham updated this revision to Diff 78366.
ngraham added a comment.
Restore elision property
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28172?vs=78126&id=78366
BRANCH
fix-vertical-panel-date-text-sizing (branched from Plasma/5.18)
REVISIO
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:01691632b523: [applets/digital-clock] Fix date sizing in
vertical panel (authored by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28172?vs=7836
