D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. ..it made no difference REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma, kmaterka Cc: kmaterka, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. > OK, one small wait won't kill the world, right? :) Not in a unit test. If it ends up not making a difference I'll revert. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma, kmaterka Cc:

D28183: [kioslave/desktop] Attempt at making test more robust

This revision was automatically updated to reflect the committed changes. Closed by commit R120:715be958eaa5: [kioslave/desktop] Attempt at making test more robust (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28183?vs=7

D28183: [kioslave/desktop] Attempt at making test more robust

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. In D28183#632057 , @davidedmundson wrote: > That won't work as is because I would need to re-run > > const KFileItem fileItem = list

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. That won't work as is because I would need to re-run const KFileItem fileItem = lister->findByUrl(destUrl); REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma Cc: kmaterka, plasma-devel, O

D28183: [kioslave/desktop] Attempt at making test more robust

kmaterka added a comment. In D28183#631966 , @davidedmundson wrote: > The failure was always on this line: > > > QCOMPARE(fileItem.targetUrl(), QUrl::fromLocalFile(destFilePath)); Oh, I see. So maybe this: `QTRY_COMPARE_WITH_TIMEO

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. Just to clarify something the failure was always on this line: > QCOMPARE(fileItem.targetUrl(), QUrl::fromLocalFile(destFilePath)); and we saw one thing still have a ".part" suffix. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabri

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson added a comment. > In theory QTRY_VERIFY should wait up to 5 seconds until condition is met. qWait(250) shouldn't change much... The big difference is that before if one spyFilesAdded is emitted after say 10ms, we'll continue immediately on with the test Whereas now w

D28183: [kioslave/desktop] Attempt at making test more robust

kmaterka added a comment. In theory `QTRY_VERIFY` should wait up to 5 seconds until condition is met. `qWait(250)` shouldn't change much... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28183 To: davidedmundson, #plasma Cc: kmaterka, plasma-devel, Orage,

D28183: [kioslave/desktop] Attempt at making test more robust

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We have an unstable test. KCoreDirLister has a timer involved set to 200ms