sitter added inline comments.
INLINE COMMENTS
> alex wrote in dictionaryrunner_config.cpp:29
> That makes sense but one question: The doc says: `...However, if you for some
> reason reimplement it and also are using KConfigXT, you must call this
> function`, does this mean we can assume that th
alex added inline comments.
INLINE COMMENTS
> sitter wrote in dictionaryrunner_config.cpp:29
> That's an implementation detail though, is it not? From the outside we
> shouldn't make assumption about what the implementation does unless the
> documentation says what we can assume.
> Today the ba
sitter added inline comments.
INLINE COMMENTS
> alex wrote in dictionaryrunner.cpp:90
> The current behavior is that KRunner closes when a match is selected.
> But if you set the data, for instance:
> `match.setData(QStringLiteral("Hello There!"));`
> The text `Hello There!` will show up in KRunn
alex added inline comments.
INLINE COMMENTS
> sitter wrote in dictionaryrunner.cpp:90
> You could simply use the lastPartOfSpeech I would guess. From what I've seen
> and what Kai tells me you really only need to set setData if you want to
> implement actions (`::actionsForMatch`) and need to c
sitter added inline comments.
INLINE COMMENTS
> config_keys.h:5
> + */
> +
> +static const char CONFIG_TRIGGERWORD[] = "triggerWord";
Include guards please
> dictionarymatchengine.cpp:85
> m_wordLock.lockForRead();
> -foreach (ThreadData *data, m_lockers.values(source)) {
> +for (T
sitter added a comment.
About fixing the UX:
There is some kind of preview tech in milou which you can take a look at and
maybe build upon.
The line space is just never going to be enough for a text only
representation of a dict entry, plus it looks fairly forced anyway. So, my
thinking
alex created this revision.
alex added reviewers: broulik, ngraham, sitter, mlaurent.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.
REVISION SUMMARY
The config key has been moved to a separate file, some foreach have been
refact
