D28289: Refactor of OverlaySheet

This revision was automatically updated to reflect the committed changes. Closed by commit R169:800fd5b04c0e: Refactor of OverlaySheet (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=79015=79016 REVISION DETAIL

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 79015. mart added a comment. - always headere when there is close button REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78616=79015 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

D28289: Refactor of OverlaySheet

ngraham added a comment. In D28289#635601 , @mart wrote: > I'm thinking to maybe *always* show the header with separator line and all even if empty when there is a close button... Makes sense to me, yeah. REPOSITORY R169 Kirigami

D28289: Refactor of OverlaySheet

mart added a comment. In D28289#635232 , @ngraham wrote: > Generally much nicer looking. I found one visual issue: when I switch from touchpad scrolling to touchscreen scrolling, the close button in the corner gets overlapped by the content

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 78616. mart marked 4 inline comments as done. mart added a comment. - adress comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78542=78616 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

D28289: Refactor of OverlaySheet

ngraham added a comment. Generally much nicer looking. I found one visual issue: when I switch from touchpad scrolling to touchscreen scrolling, the close button in the corner gets overlapped by the content area since the scroll track gets narrower. INLINE COMMENTS > OverlaySheet.qml:24 >

D28289: Refactor of OverlaySheet

anthonyfieroni added inline comments. INLINE COMMENTS > OverlaySheet.qml:2-19 > +* Copyright (C) 2016 by Marco Martin > +* > +* This program is free software; you can redistribute it and/or modify > +* it under the terms of the GNU Library General Public License as > +* published by the

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 78542. mart added a comment. - better response to window resizes REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78532=78542 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 78532. mart added a comment. - Merge branch 'master' into mart/overlaysheetrefactor2 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78482=78532 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

D28289: Refactor of OverlaySheet

ngraham added a comment. FWIW this needs a rebase as there were apparently some changes to OverlaySheet on master since this was branched. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28289 To: mart, #kirigami Cc: ngraham, plasma-devel, fbampaloukas, GB_2,

D28289: Refactor of OverlaySheet

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY Rework OverlaySheet to remove some sizing hacks that made ListView and GridView not work well, fix