This revision was automatically updated to reflect the committed changes.
Closed by commit R133:c103ceb1caf0: Add support for logging categories
(authored by romangg).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28389?vs=78881&id=79092
REVISION DETAI
romangg added inline comments.
INLINE COMMENTS
> apol wrote in CMakeLists.txt:23
> Make sure the include() call is before the add_subdirectory().
>
> That's why we usually put them together on top right under the find_package()
> together with `include(ECMGenerateHeaders)`.
Put the include on
romangg updated this revision to Diff 78881.
romangg added a comment.
Include the cpp files
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28389?vs=78765&id=78881
BRANCH
logging-categories
REVISION DETAIL
https://phabricator.kde.org/D28389
AFFE
apol added a comment.
Other than that, the patch looks good. +1
INLINE COMMENTS
> romangg wrote in CMakeLists.txt:23
> Any idea how to reuse the declaration from the top-directory CMake file?
Make sure the include() call is before the add_subdirectory().
That's why we usually put them toget
romangg added inline comments.
INLINE COMMENTS
> CMakeLists.txt:23
> +Critical
> +)
> +
Any idea how to reuse the declaration from the top-directory CMake file?
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D28389
To: romangg, #plasma
Cc: plasma-devel,
romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.
REVISION SUMMARY
Adds category logging to the KScreenLocker daemon/library and the greeter.
Replaces all curre
