bshah updated this revision to Diff 79013.
bshah added a comment.
- change signal name, notify caused confusion with notify of QObj
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28455?vs=78978&id=79013
BRANCH
bshah/ksld-dbus-notify
REVISION DETAI
bshah updated this revision to Diff 78978.
bshah added a comment.
- proper object instead of QMetaObject invokeMethod
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28455?vs=78968&id=78978
BRANCH
bshah/ksld-dbus-notify
REVISION DETAIL
https://ph
bshah planned changes to this revision.
bshah added a comment.
I need to add methods for the communicating the actions back to notification
server.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D28455
To: bshah
Cc: davidedmundson, plasma-devel, Orage, LeGast0
bshah added inline comments.
INLINE COMMENTS
> davidedmundson wrote in greeterapp.cpp:497
> This pattern of fetching and poking the root object of a scene isn't one I
> like, it's better to expose an object to the view that then has normal
> signals and slots - but this does follow the conventi
bshah updated this revision to Diff 78968.
bshah added a comment.
- fixup comments mentioned by David
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28455?vs=78952&id=78968
BRANCH
bshah/ksld-dbus-notify
REVISION DETAIL
https://phabricator.kde.or
davidedmundson added a comment.
I'd say we go for the simplest solution +++
Given we have MPRIS on here, if we were to do any DBus lockdowns we would
almost certainly want to use xdg-dbus-proxy, at which point this would continue
to work.
INLINE COMMENTS
> greeterapp.cpp:139
> +(vo
bshah created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.
REVISION SUMMARY
Currently this dbus interface allows the notification server to pass the
notifications, which then are forwarded to greeter theme by c
