D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

mart added a comment. in the end, just centered vertically the sheet in 812238afdcb7 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28664 To: cblack, #kirigami Cc: mart, ngraham, plasma-de

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

mart added a comment. so in the end, vertical centering? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28664 To: cblack, #kirigami Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

ngraham added a comment. Okay. But then the difference between a sheet and a dialog is inherently nebulous: a short sheet is like a dialog; a tall dialog is like a sheet. In my mind it makes sense to use one thing for both and tweak the presentation accordingly. Clearly lots of people are us

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

cblack added a comment. In D28664#646279 , @ngraham wrote: > Well, one of the ideas of Kirigami is to not spawn new windows when not needed. The Dialog in QQC2 (not to be confused with the dialog from QtQuick Dialogs) isn't a separate wi

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

ngraham added a comment. Well, one of the ideas of Kirigami is to not spawn new windows when not needed. Maybe the basic QQC2 popup (which does open centered) needs to gain the same visual style as an OverlaySheet. Or maybe OverlaySheet should be able to be used as a centered pop-up thingy.

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

cblack added a comment. In D28664#646254 , @ngraham wrote: > I think it would be better to vertically center in this case instead of adding a fixed bottom margin. The result with the patch in its current state is better, but IMO could still be i

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

ngraham added a comment. I think it would be better to vertically center in this case instead of adding a fixed bottom margin. The result with the patch in its current state is better, but IMO could still be improved: F8232058: Screenshot_20200411_180348.png