This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9dba4c8b1583: Document Kirigami::Icon (authored by
cblack).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D28688?vs=79787&id=80709#toc
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
h
cblack updated this revision to Diff 79787.
cblack marked 10 inline comments as done.
cblack added a comment.
Address feedback
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28688?vs=79744&id=79787
BRANCH
cblack/document-icon (branched from master)
REV
cblack updated this revision to Diff 79744.
cblack added a comment.
Fix Doxygen issues
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28688?vs=79669&id=79744
BRANCH
cblack/document-icon (branched from master)
REVISION DETAIL
https://phabricator.kde.o
cblack planned changes to this revision.
cblack added a comment.
Those `@include`s aren't resolving properly, will fix
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D28688
To: cblack, #kirigami
Cc: broulik, nicolasfella, plasma-devel, fbampaloukas, GB_2, domson,
d
broulik added a comment.
Generally +1 on better docs
INLINE COMMENTS
> icon.h:53
> +/**
> + * The name of a fallback icon to load from the icon theme when the
> `source`
> + * cannot be found.
Mention `Default is "unknown"`
> icon.h:58
> + *
> + * @note This will only
cblack added inline comments.
INLINE COMMENTS
> nicolasfella wrote in icon.h:69
> Maybe mention that it's read-only. Do we have some standard way of doing that?
It's mentioned by Doxygen
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D28688
To: cblack, #kirigami
Cc:
nicolasfella added a comment.
+1
documentation improvements are always very welcome
INLINE COMMENTS
> icon.h:37
> + * @include icon/FilesystemSource.qml
> + * * The Internet:
> + * @include icon/InternetSource.qml
Maybe instead of internet something like "a remote url" since it
cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.
REVISION SUMMARY
There are now documentation comments for Kirigami::Icon.
REPOSITORY
R169 Kirigami
BRANCH
cb
