D28698: Save unneeded DBus roundtrip

This revision was automatically updated to reflect the committed changes. Closed by commit R116:eec18ad4f337: Save unneeded DBus roundtrip (authored by nicolasfella). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28698?vs=79689&id=797

D28698: Save unneeded DBus roundtrip

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. In D28698#644705 , @davidedmundson wrote: > > (the ugly notification which pops on the top of screen) when Plasma notifications are not r

D28698: Save unneeded DBus roundtrip

davidedmundson added a comment. > (the ugly notification which pops on the top of screen) when Plasma notifications are not ready yet Plasma ships a trick for that which means that we always get plasma notifications when plasma is installed regardless of if it's running. REPOSITORY R1

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. I see that we already initialize the secret agent right when the kded module is loaded, but I see a potential problem in showing a notification using a fallback backend (the ugly notification which pops on the top of screen) when Plasma notifications are not ready y

D28698: Save unneeded DBus roundtrip

nicolasfella added a comment. I see, that makes sense REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28698 To: nicolasfella, #plasma, jgrulich Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampalo

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. Actually it was me who pushed this, Lukáš just did some changes to it. Here are some details: https://cgit.kde.org/plasma-nm.git/commit/?id=81839a1566d0c0209a308d71b03837f996a19c96 REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://pha

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. In D28698#644698 , @nicolasfella wrote: > Yes, but I don't see this being a problem I think this was done this way to make the kded module used only when either the applet or KCM is running. It was Lukáš Tinkl w

D28698: Save unneeded DBus roundtrip

nicolasfella added a comment. Yes, but I don't see this being a problem REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28698 To: nicolasfella, #plasma, jgrulich Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D28698: Save unneeded DBus roundtrip

jgrulich added a comment. In D28698#644695 , @broulik wrote: > Isn't that `Handler` also used from the plasmoid and KCM, which is in a separate process from kded? It is. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D28698: Save unneeded DBus roundtrip

broulik added a comment. Isn't that `Handler` also used from the plasmoid and KCM, which is in a separate process from kded? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D28698 To: nicolasfella, #plasma, jgrulich Cc: broulik, plasma-devel,

D28698: Save unneeded DBus roundtrip

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY When the module is loaded the handler is notifie