This revision was automatically updated to reflect the committed changes.
Closed by commit R116:7e65fd05b38e: Refactor and fix the mobile wifi kcm
(authored by tfella).
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28799?vs=80143&id=8
tfella updated this revision to Diff 80143.
tfella marked an inline comment as done.
tfella added a comment.
More fixes
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28799?vs=80076&id=80143
BRANCH
mobileWifiFix (branched from ma
nicolasfella added inline comments.
INLINE COMMENTS
> NetworkSettings.qml:27
> SimpleKCM {
> +id: networkSettings
> property var path
not needed
> wifisettings.cpp:65
>
> +if(type == "secrets")
> +return
> con->secrets(QLatin1String("802-11-wireless-security")).value().
jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.
I wanted to let @ngraham to review this UI wise, but I see there are no UI
changes. I don't follow mobile KCM development so I'm not sure I'm the right
person to review this, but it loo
tfella updated this revision to Diff 80076.
tfella added a comment.
Minor Fixes
REPOSITORY
R116 Plasma Network Management Applet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28799?vs=80029&id=80076
BRANCH
mobileWifiFix (branched from master)
REVISION DETAIL
https://phabric
tfella created this revision.
tfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
tfella requested review of this revision.
REVISION SUMMARY
Previous refactoring and existing errors made editing connections
