dfaure created this revision.
dfaure added reviewers: davidedmundson, sitter.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.
REVISION SUMMARY
Is there a better way to report error from this code than the dialog box
that KRun u
broulik added a comment.
In principle dataengine actions are jobs, so they could communicate a result
back
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28988
To: dfaure, davidedmundson, sitter
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev
dfaure added a comment.
As it is currently implemented, CommandLauncherJob is very unlikely to ever
fail. It doesn't even fail on non-existing executable in the command (because
it delegates to bash) so apart from QProcess cannot fork, it never fails.
Probably not worth doing something compl
dfaure updated this revision to Diff 80970.
dfaure added a comment.
Remove question from commit message
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28988?vs=80969&id=80970
BRANCH
arcpatch-D28988
REVISION DETAIL
https://phabricator.kde.org/
dfaure updated this revision to Diff 80969.
dfaure added a comment.
Use KNotificationJobUiDelegate
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28988?vs=80566&id=80969
BRANCH
arcpatch-D28988
REVISION DETAIL
https://phabricator.kde.org/D2898
dfaure closed this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D28988
To: dfaure, davidedmundson, sitter, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himc
