D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#669970 , @dvratil wrote: > If I may add my two cents here, Hi Daniel, sorry for the late reply. But I was busy as I had to kick things off now with the libkscreen fork. > I agree with David that

D29024: feat(wayland): support multiple protocol extensions through plugin system

dvratil added a comment. If I may add my two cents here, I agree with David that introducing a plugin for a plugin is a bit over the top. Whats the issue with contributing your backend into libkscreen upstream instead? If there's any code that could be shared between KWayland backend and

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. Oh I nearly forgot: great work that you ignore everything else I wrote and only reply to the most unimportant statement in all of that. That's a great rhetorical trick. Every good politician must know about this one for distraction. REPOSITORY R110 KScreen

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#669718 , @davidedmundson wrote: > > Show me where the documentation for this QtWaylandClientExtension is and where you documented that we "agreed" on using that in Plasma exclusively and we can talk about

D29024: feat(wayland): support multiple protocol extensions through plugin system

davidedmundson added a comment. > Show me where the documentation for this QtWaylandClientExtension is and where you documented that we "agreed" on using that in Plasma exclusively and we can talk about libkscreen using it in 5.20 It was documented here

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#668884 , @ngraham wrote: > In D29024#668383 , @romangg wrote: > > > Note that I need to have this plugin system or something similar in for 5.19 or I will be

D29024: feat(wayland): support multiple protocol extensions through plugin system

davidedmundson added a comment. > These are not specific issues but some general complains about the overall concept chosen here without providing an alternative solution. Well yes, it makes sense to do high level discussion first. With the Plasma agreed "new approach" that we will

D29024: feat(wayland): support multiple protocol extensions through plugin system

ngraham added a comment. In D29024#668383 , @romangg wrote: > Note that I need to have this plugin system or something similar in for 5.19 or I will be forced to fork libkscreen permanently for KWinFT. I would like to avoid this and instead

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. These are not specific issues but some general complains about the overall concept chosen here without providing an alternative solution. I chose this plugin system because it allows robust extension to the current system. Plugins are well contained and reuse

D29024: feat(wayland): support multiple protocol extensions through plugin system

davidedmundson added a comment. It's still got this pointless plugin within plugin situation. > For that at least one Wayland event loop has to be launched It needs a roundrip after the registry is fetched. That doesn't need an event loop. REPOSITORY R110 KScreen Library

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. Since this has now the structure with exported headers as requested in D29028#653150 and D29028#654526 I'll push later today if there are no more specific issues pointed out in

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. A separate library KScreenWayland is installed additionally to the runtime plugin, so that library can be linked against to create nested plugins for a Wayland session. These plugins must be installed in a certain directory

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg updated this revision to Diff 82265. romangg added a comment. - refactor: export Wayland plugins headers REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29024?vs=80700=82265 BRANCH wayland-plugins-export REVISION DETAIL

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#653096 , @davidedmundson wrote: > KScreen already is a plugin system. You mean libkscreen? It has a plugin system for differentiating between windowing systems, yes. > We don't need to go all

D29024: feat(wayland): support multiple protocol extensions through plugin system

davidedmundson added a comment. KScreen already is a plugin system. We don't need to go all inception, and have a plugin load plugins. It doesn't look to bring anything other than complexity. If there is any duplication, we can just add some extra base classes in the lib using the

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg updated this revision to Diff 80700. romangg added a comment. Cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29024?vs=80698=80700 BRANCH wayland-plugins REVISION DETAIL https://phabricator.kde.org/D29024 AFFECTED FILES

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:28 > +TARGETS LibkscreenWaylandPluginKWayland > +DESTINATION ${PLUGIN_INSTALL_DIR}/org.kde.libkscreen.backends/wayland/ > +) That directory fine or are there other suggestions? I would like to centralize over time all

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg updated this revision to Diff 80698. romangg added a comment. Cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29024?vs=80695=80698 BRANCH wayland-plugins REVISION DETAIL https://phabricator.kde.org/D29024 AFFECTED FILES

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Besides the KWayland output-management protocol there exist other protocol extensions for