D29028: feat(wayland): add Wrapland plugin

2020-05-08 Thread Roman Gilg
romangg abandoned this revision. romangg added a comment. Will become an external plugin with libkscreen Wayland headers being exported now. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D29028 To: romangg, #plasma, davidedmundson, apol Cc: anthonyfieroni,

D29028: feat(wayland): add Wrapland plugin

2020-04-22 Thread Roman Gilg
romangg added a comment. In D29028#654542 , @davidedmundson wrote: > A new dependency also needs to actually solve an actual problem. > > If we say we should support wl_roots' protocol for wlroots users. Fair enough. There are some parts of

D29028: feat(wayland): add Wrapland plugin

2020-04-22 Thread Roman Gilg
romangg added a comment. In D29028#654535 , @anthonyfieroni wrote: > In D29028#653194 , @romangg wrote: > > > In D29028#653192 , @apol wrote: > > > >

D29028: feat(wayland): add Wrapland plugin

2020-04-22 Thread Roman Gilg
romangg added a comment. In D29028#654526 , @tcanabrava wrote: > I understand David's point: Wrapland project has one developer and we don't know how successful it will be, while the other backends have developers. What would happen if you

D29028: feat(wayland): add Wrapland plugin

2020-04-22 Thread David Edmundson
davidedmundson added a comment. A new dependency also needs to actually solve an actual problem. If we say we should support wl_roots' protocol for wlroots users. Fair enough. There are some parts of Plasma used by 3rd parties. I'd certainly be very happy for us both to switch to a

D29028: feat(wayland): add Wrapland plugin

2020-04-22 Thread Anthony Fieroni
anthonyfieroni added a comment. In D29028#653194 , @romangg wrote: > In D29028#653192 , @apol wrote: > > > I don't really see why we'd want to support something that is not offering ABI stability

D29028: feat(wayland): add Wrapland plugin

2020-04-22 Thread Tomaz Canabrava
tcanabrava added a comment. I understand David's point: Wrapland project has one developer and we don't know how successful it will be, while the other backends have developers. What would happen if you suddenly quit / disappear and the project dies? Then kscreen will have a folder of dead

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread Roman Gilg
romangg added a comment. In D29028#653192 , @apol wrote: > I don't really see why we'd want to support something that is not offering ABI stability and doesn't push Plasma in any direction. It is offering in the same way ABI stability as

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. I don't really see why we'd want to support something that is not offering ABI stability and doesn't push Plasma in any direction. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D29028 To:

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread Roman Gilg
romangg added a comment. In D29028#653150 , @davidedmundson wrote: > I don't see why we should have that in KDE code. Come on man, do you really want to make this ugly? I thought we would still treat each other with respect David. :(

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't see why we should have that in KDE code. As per manifesto > The project stays true to established practices common to similar KDE projects

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds a plugin that uses the Wrapland library to interact with compositors supporting the