D29152: Allow PlaceholderMessage to be text-less

2020-04-24 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R169:d2969c7af79b: Allow PlaceholderMessage to be text-less (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29152?vs=81097&id=81099 REVISION DETA

D29152: Allow PlaceholderMessage to be text-less

2020-04-24 Thread Nathaniel Graham
ngraham updated this revision to Diff 81097. ngraham marked an inline comment as done. ngraham added a comment. Simplify REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29152?vs=81095&id=81097 BRANCH allow-PlaceholderMessage-to-omit-text (branched from m

D29152: Allow PlaceholderMessage to be text-less

2020-04-24 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:220 > > +visible: text && text.length > 0 > + `text` is a string property and as such always present, you can simplify this to visible: text !== "" or visible: text.length > 0 REPOSITORY R169 Kirigami RE

D29152: Allow PlaceholderMessage to be text-less

2020-04-24 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: iasensio, mart, Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Requested by @iasensio for the KWin Rules KCM patch (D29141