davidedmundson added inline comments.
INLINE COMMENTS
> romangg wrote in Output.qml:60
> Is the change making this unnecessary? I.e. do the graphics still look
> "smooth"?
Default is true so it makes no difference.
There's generally no reason to set it to false.
REPOSITORY
R104 KScreen
REV
This revision was automatically updated to reflect the committed changes.
Closed by commit R104:cfd95e6bff4b: fix(kcm): avoid recursive OpacityMask which
leads to teardown crash (authored by davidedmundson).
REPOSITORY
R104 KScreen
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29340
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
> Docs explicitly say this.
When you reference some "docs" please take 20 seconds and directly link it.
Every piece you write here and in git commit messages is potentially read by
h
davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
In the current code OpacityMask's source is the parent which contains
itself, which doesn't make sense. Docs explici
