This revision was automatically updated to reflect the committed changes.
Closed by commit R120:68601675d13b: [sddm-theme] Prevent the logo from leaking
in after a fadeout (authored by filipf).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29351?vs=8
filipf added a comment.
Is this okay now @mart and okay to land on 5.18?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29351
To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, f
ngraham added a comment.
Wait for @mart, but landing on the stable branch seems safe. No need for a
bug report if there isn't already one open.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29351
To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma
filipf added a comment.
Should I also land this for 5.18 (do I have to create a bug report first)?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29351
To: filipf, ngraham, cblack, #plasma, mart
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cb
filipf updated this revision to Diff 81910.
filipf marked an inline comment as done.
filipf added a comment.
Replace PropertyAnimation with NumberAnimation
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29351?vs=81709&id=81910
BRANCH
no-logo-lea
mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.
unfortunately yeah, i had to port away from opacityanimator several places
for this reason :(
INLINE COMMENTS
> Main.qml:449
> +// OpacityAnimator when starting from
filipf updated this revision to Diff 81709.
filipf added a comment.
Ditch OpacityAnimator and use PropertyAnimation
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29351?vs=81707&id=81709
BRANCH
no-logo-leak (branched from master)
REVISION DETAI
filipf added a comment.
This kills the animation though... I found this comment in other code:
"//OpacityAnimator when starting from 0 is buggy (it shows one frame with
opacity 1)"
I'm able to get this opacity fading effect though without the bug if I switch
from using OpacityAnimator
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.
REVISION SUMMARY
Even when the vendor logo is turned off it can be briefly seen when the login
screen changes from the fadeout state back into normal.
