D29394: Add photographic user avatars

This revision was automatically updated to reflect the committed changes. Closed by commit R128:13e73011b1ac: Add photographic user avatars (authored by filipf). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82748=82762 REVISION DETAIL

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. Shipit! REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n,

D29394: Add photographic user avatars

filipf updated this revision to Diff 82748. filipf added a comment. don't delete user_manager.kdev4 REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82746=82748 BRANCH add-photo-avatars (branched from master) REVISION DETAIL

D29394: Add photographic user avatars

filipf updated this revision to Diff 82746. filipf added a comment. Make as REUSE compliant as possible REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82732=82746 BRANCH add-photo-avatars (branched from master) REVISION DETAIL

D29394: Add photographic user avatars

filipf added a comment. In D29394#670076 , @ngraham wrote: > The .license files could live in another folder. Maybe `src/pics_sources`? Yeah I can do that as well REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from

D29394: Add photographic user avatars

ngraham added a comment. The .license files could live in another folder. Maybe `src/pics_sources`? REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb,

D29394: Add photographic user avatars

filipf added a comment. In D29394#670030 , @jriddell wrote: > Looks good for licence freedom > > Could you make the licence info in format specified at https://reuse.software/tutorial/ ? It's what we want to use from now on in KDE. > >

D29394: Add photographic user avatars

jriddell added a comment. Looks good for licence freedom Could you make the licence info in format specified at https://reuse.software/tutorial/ ? It's what we want to use from now on in KDE. So add cat.jpg.license files with SPDX header lines saying CC0 and add

D29394: Add photographic user avatars

filipf updated this revision to Diff 82732. filipf added a comment. rework licensing stucture due to a flaw in user_manager (it shows every single file in the avatar gallery and the .license files break it) REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D29394: Add photographic user avatars

ngraham added a comment. @jriddell, does this licensing situation look sane? REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, plasma-devel, Orage,

D29394: Add photographic user avatars

filipf updated this revision to Diff 82697. filipf added a comment. Use this format https://reuse.software/tutorial/ making a LICENCE/ directory with the licence text in it and cat.jpg.license with the SPDX header REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. Perfecto. REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n,

D29394: Add photographic user avatars

filipf updated this revision to Diff 82694. filipf added a comment. actually remove Chip and Gecko(due to rename) REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82693=82694 BRANCH add-photo-avatars (branched from master) REVISION DETAIL

D29394: Add photographic user avatars

filipf updated this revision to Diff 82693. filipf added a comment. - rename Gecko to Chameleon because that wasn't a gecko - remove Chip - add Air Balloon, Dog, Fish, Owl, Pencils, Sushi - WIP: licence files REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. Awesome. Love the pancakes, the gecko, and the new gaming controller. Much nicer. I really like Doggo, AirBalloon, Pencils, and Sushi, and think those might be worth including as well. I also kind of like Fish too! Chip seems

D29394: Add photographic user avatars

filipf added a comment. Some pictures I didn't include in case people like them: F8313250: image.png F8313256: image.png (yes the Leopard is nice but the circular cropping eats too much into it) With

D29394: Add photographic user avatars

filipf updated this revision to Diff 82662. filipf added a comment. - Remove all Unsplash and Pexels licensed photos to avoid complications. - Use CC0 pictures from Pexels instead - Licence files to be added REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D29394: Add photographic user avatars

jriddell added a comment. Oh yes I made the rookie error of not reading to the end, Unsplash is not free and we can't use it. REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc:

D29394: Add photographic user avatars

filipf added a comment. IANAL but the Pexels and Unsplash licence look the same to me: free to distribute, free to modify, no attribution needed, but don't use it to make a Pexels/Unsplash clone. Someone once noted that neither exists in some FOSS licence database. I'll just ask everyone to

D29394: Add photographic user avatars

ognarb added a comment. CC-0 or any license compatible with CC-BY-SA-4.0 are fine. The Unsplash license is non-free too: "This license does not include the right to compile photos from Unsplash to replicate a similar or competing service. ". REPOSITORY R128 User Manager BRANCH

D29394: Add photographic user avatars

jriddell added a comment. We can't use anything under that Pexels licence, it's non-free. Unsplash and CC0 are good to use. They both explicitly don't need attribution (which is pretty generous), but it's nice to do so and helps clarity in future. Preferably use this format

D29394: Add photographic user avatars

filipf added a comment. After additional consideration, I'm not too happy with the car avatar but I did find this: F8292121: Screenshot_20200507_090804.png Speaking of licences, I assume I can leave the CC0 ones at CC0, while the rest should

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Everything looks great to me! Now go ask for re-licensing, I suppose. REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL

D29394: Add photographic user avatars

filipf updated this revision to Diff 81955. filipf added a comment. Drop: - Air Balloon - Gamepad Add: - Architecture - Food - Chalk Change: - Embiggen the leopard REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D29394: Add photographic user avatars

ngraham added a comment. In D29394#663180 , @filipf wrote: > In D29394#663012 , @ngraham wrote: > > > This is an improvement, for sure. But what happened to the noodle bowl? I loved that one! >

D29394: Add photographic user avatars

filipf added a comment. In D29394#663012 , @ngraham wrote: > Great, that works. I suppose there's no point in fixing that bug since this KCM is being re-done anyway in D28154 . Once this lands, @cblack can

D29394: Add photographic user avatars

ngraham added a subscriber: cblack. ngraham added a comment. Great, that works. I suppose there's no point in fixing that bug since this KCM is being re-done anyway in D28154 . Once this lands, @cblack can grab these and add them to that patch.

D29394: Add photographic user avatars

filipf added a comment. In D29394#662776 , @ognarb wrote: > Photo using the Unsplash license can't be included in our repositories. The license is not considered open-source :( We should contact the artists if they are willing to license their

D29394: Add photographic user avatars

ognarb added a comment. Photo using the Unsplash licence can't be included in our repositories. The license is not consired open source :( REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: ognarb, plasma-devel, Orage,

D29394: Add photographic user avatars

filipf updated this revision to Diff 81839. filipf added a comment. probably don't want to include the .directory file REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=81838=81839 BRANCH add-photo-avatars (branched from master) REVISION

D29394: Add photographic user avatars

filipf updated this revision to Diff 81838. filipf added a comment. Better file naming REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=81829=81838 BRANCH add-photo-avatars (branched from master) REVISION DETAIL

D29394: Add photographic user avatars

filipf added a comment. Alright, I believe the issue is with the fact that the avatar gallery is coded to always look for avatars in the system `/usr/share` dir as opposed to adjusting to testing conditions and using the local `/usr/share` dir. `sudo cp -r

D29394: Add photographic user avatars

filipf added a comment. The permissions are wrong if we do `sudo make install` (the photos folder ends up being root owned). But it doesn't show up with `make install` either. Will investigate more in the morning. REPOSITORY R128 User Manager REVISION DETAIL

D29394: Add photographic user avatars

ngraham added a comment. Love the images! Do they actually show up for you in the KCM though? They don't for me. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29394: Add photographic user avatars

filipf created this revision. filipf added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch adds 12 photographic avatars in order to finish work on T9910

D29394: Add photographic user avatars

filipf added a comment. Sources: Basketball: https://www.pexels.com/photo/basketball-net-2169302/ (Pexels licence) Brushes: https://www.pexels.com/photo/abstract-art-artist-artistic-262034/ (CC0 licence) Car: https://www.pexels.com/photo/action-asphalt-auto-racing-automobile-274974