alex closed this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29726
To: alex, #plasma, ngraham, meven, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, leslie
alex updated this revision to Diff 82954.
alex added a comment.
Adjust docstring for Browser::updateCacheFile
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29726?vs=82946&id=82954
BRANCH
avid_unnecessary_copying (branched from master)
REVISION
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
Seems good to me
REPOSITORY
R120 Plasma Workspace
BRANCH
avid_unnecessary_copying (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29726
To: alex, #plasma, ngraham,
alex updated this revision to Diff 82946.
alex added a comment.
Use enum for caching return type
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29726?vs=82790&id=82946
BRANCH
avid_unnecessary_copying (branched from master)
REVISION DETAIL
htt
alex added inline comments.
INLINE COMMENTS
> meven wrote in chrome.cpp:55
> Might as well check the returned value for error
If this fails only the icons are affected and the default icon will be
displayed, this case will be handled in the FetchSqlite class
> meven wrote in fetchsqlite.cpp:42
alex added inline comments.
INLINE COMMENTS
> meven wrote in fetchsqlite.cpp:87
> We might want to reuse database connection as long as the databaseFile did
> not change
I will do that in a follow up patch :-)
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2
meven added inline comments.
INLINE COMMENTS
> chrome.cpp:55
> for(const Profile &profile : profiles) {
> +updateCacheFile(profile.faviconSource(), profile.faviconCache());
> m_profileBookmarks << new ProfileBookmarks(profile);
Might as well check the returned value for err
alex updated this revision to Diff 82790.
alex added a comment.
Add space
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29726?vs=82789&id=82790
BRANCH
avid_unnecessary_copying (branched from master)
REVISION DETAIL
https://phabricator.kde.or
alex updated this revision to Diff 82789.
alex retitled this revision from "WIP BookmarksRunner: Change caching
databases" to "BookmarksRunner: Change caching databases".
alex edited the summary of this revision.
alex edited the test plan for this revision.
alex added a comment.
Copy chrome fi
