D4842: [System Tray] Listen to external collapse

2017-03-03 Thread Kai Uwe Broulik
broulik abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4842 To: broulik, #plasma Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

2017-03-01 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D4842#90987, @broulik wrote: > Of course I meant the code in panel containment, but here it does expanded = false and that's what I wanted to listen to :) > > Plasmoid.onUserConfiguringChanged: { > ... > if (pl

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

2017-02-28 Thread Kai Uwe Broulik
broulik added a comment. Of course I meant the code in panel containment, but here it does expanded = false and that's what I wanted to listen to :) Plasmoid.onUserConfiguringChanged: { ... if (plasmoid.userConfiguring) { for (var i = 0; i < plasmoid.

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

2017-02-28 Thread Marco Martin
mart added a comment. i don't think the panel controller does that, but would be easy to do so? (in the panel containment, when isuserconfiguring proeprty changes) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4842 EMAIL PREFERENCES https://phabricator.

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

2017-02-28 Thread Kai Uwe Broulik
broulik added a comment. Hold on, I didn't properly test this. It closes because of the controller window gaining focus, my idea was to also have it close when the pin is checked which this patch doesn't fix. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D

[Differential] [Request, 6 lines] D4842: [System Tray] Listen to external collapse

2017-02-28 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When plasmoid.expanded = false is done, hide the popup. This is done by the panelcontroller to ensure we don't manipulate the panel with ope