broulik abandoned this revision.
broulik added a comment.
Somehow I must have screwed up my setup somehow, I can't reproduce the issues
I had anymore and never had it on my laptop to begin with.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4923
To: broul
broulik added a comment.
Taking for example the context menu code in FolderView:
It does `KFileItem = m_dirModel->itemForIndex(index);`
`item.localPath()`: `""`
`item.isLocalFile()`: `false`
`item.mostLocalUrl()`: `QUrl("desktop:/foo")`
`item.targetUrl():` `QUrl("desktop:/foo")`
dfaure added a comment.
KFileItem::localPath() should not ever ever be a URL like desktop:/. That
would be very wrong.
It just returns what you set in UDS_LOCAL_PATH, so it's kio_desktop you
should debug, not kio ;)
Well except for KIO::ForwardingSlaveBase, called by kio_desktop -- note t
broulik added a comment.
For some reason the `UDS_LOCAL_PATH` isn't properly filled, KFileItem
localPath() is still desktop:/ but I got lost in KIO code trying to figure it
out :(
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4923
To: broulik, #plasma, h
anthonyfieroni added a comment.
It's look like relative path to me. If i'm not wrong KFileItem::setLocalPath
should resolve relative path ?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4923
To: broulik, #plasma, hein, dfaure
Cc: anthonyfieroni, plasma-de
broulik added a comment.
I don't know. The rewritten url for desktop:/ is clean (/home/foo/Desktop)
but in KFileItem I see tons of places that are like path + '/' + name but I
haven't figured out where the "." actuall comes from...
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https:
dfaure added a comment.
QDir::cleanPath or QUrl::NormalizePathSegments can help making this fix more
generic.
But I'm curious, where does the "/." come from in the first place?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4923
To: broulik, #plasma,
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When dragging a file from one desktop:/ to another desktop:/ KIO wouldn't
notice it's the same location as the source would be
`file://home/
broulik edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4923
To: broulik, #plasma, hein, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
