This revision was automatically updated to reflect the committed changes.
mart marked 2 inline comments as done.
Closed by commit R242:bbcb217b4812: actually delete old theme caches (authored
by mart).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.k
davidedmundson added inline comments.
INLINE COMMENTS
> theme_p.cpp:271
> +for (const QFileInfo &file : cacheDir.entryInfoList()) {
> +if (!file.absoluteFilePath().endsWith(svgElementsFileName)) {
> +QFile::remove(file.absoluteFilePath());
do we not want
if (
sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.
lgtm
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
arcpatch-D4925
REVISION DETAIL
https://phabricator.kde.org/D4925
To: mart, #plasma, sitter
Cc: sitter, apol, plasma-devel, #fr
mart updated this revision to Diff 12262.
mart added a comment.
use QFileInfo
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4925?vs=12133&id=12262
BRANCH
arcpatch-D4925
REVISION DETAIL
https://phabricator.kde.org/D4925
AFFECTED FI
apol added inline comments.
INLINE COMMENTS
> theme_p.cpp:221
> +
> +for (const QString &file : cacheDir.entryList()) {
> if (currentCacheFileName.isEmpty() ||
Use entryInfoList? This way you won't have to construct the path again...
> theme_p.cpp:270
> +
> +
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
QStandardPaths doesn't do file search by wildcards,
that code was never actually functional
TEST PLAN
old kcache and re
