This revision was automatically updated to reflect the committed changes.
Closed by commit R108:8672b93bdd14: Add support for screenedge touchscreen
events through XInput 2.2 (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5137?vs=12767&id
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
BRANCH
screenedge-touch-xinput
REVISION DETAIL
https://phabricator.kde.org/D5137
To: graesslin, #plasma, #kwin, davidedmundson
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensre
graesslin updated this revision to Diff 12767.
graesslin added a comment.
Next try
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5137?vs=12748&id=12767
BRANCH
screenedge-touch-xinput
REVISION DETAIL
https://phabricator.kde.org/D5137
AFFECTED FILES
gestures.h
plugins/platf
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xinputintegration.cpp:132
> you've reordered this now.
>
> const auto last = m_lastTouchPositions.value(e->detail);
>
> needs to happen before you update m_lastTouchPositions
argh, it gets embarrassing
REVISION DETAIL
davidedmundson added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xinputintegration.cpp:132
> Sorry that's not quite what i meant
>
> m_lastTouchPositions now needs to use e->detail
>
> And the gestureRecognizer stuff should still be inside the if.
you've reordered this now.
con
graesslin updated this revision to Diff 12748.
graesslin added a comment.
Try two :-)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5137?vs=12714&id=12748
BRANCH
screenedge-touch-xinput
REVISION DETAIL
https://phabricator.kde.org/D5137
AFFECTED FILES
gestures.h
plugins/pl
davidedmundson added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xinputintegration.cpp:132
> I think we want to always update m_lastTouchPositions outside of
> if (e->detail == m_trackingTouchId)
>
> otherwise if we get:
>
> TouchBegin
> TouchUpdate
> TouchOwnership
>
> we star
graesslin updated this revision to Diff 12714.
graesslin marked an inline comment as done.
graesslin added a comment.
Addressed David's comments
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5137?vs=12701&id=12714
BRANCH
screenedge-touch-xinput
REVISION DETAIL
https://phabrica
graesslin marked 2 inline comments as done.
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xinputintegration.cpp:188
> what's this for?
left over from previous approach.
REVISION DETAIL
https://phabricator.kde.org/D5137
To: graesslin, #plasma, #kwin
Cc: davidedmun
davidedmundson added a comment.
cool
INLINE COMMENTS
> xinputintegration.cpp:132
> +m_lastTouchPosition = touchPosition;
> +m_lastTouchPositions.insert(m_trackingTouchId,
> touchPosition);
> +}
I think we want to always update m_lastTouchPositions
graesslin added dependencies: D5106: Add support for activating screenedges
through touch swipe gestures, D5097: Add support for global touchpad swipe
gestures.
REVISION DETAIL
https://phabricator.kde.org/D5137
To: graesslin, #plasma, #kwin
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed
graesslin created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This change extends the XInputEventFilter to also listen for all touch
events on the root window.
The touch points are passed to the n
12 matches
Mail list logo
