This revision was automatically updated to reflect the committed changes.
Closed by commit R108:8ef184e1cd1b: Implement high DPI support in KWin QPA
(authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5172?vs=12807&id=13982
REVISION DETA
graesslin added a comment.
the accepted still holds :-)
BRANCH
scaling_final
REVISION DETAIL
https://phabricator.kde.org/D5172
To: davidedmundson, #plasma, graesslin
Cc: graesslin, markg, plasma-devel, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol
davidedmundson updated this revision to Diff 12807.
davidedmundson added a comment.
fixed spacing
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5172?vs=12801&id=12807
BRANCH
scaling_final
REVISION DETAIL
https://phabricator.kde.org/D5172
AFFECTED FILES
plugins/qpa/screen.cp
davidedmundson updated this revision to Diff 12801.
davidedmundson added a comment.
Updated
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5172?vs=12789&id=12801
BRANCH
scaling_final
REVISION DETAIL
https://phabricator.kde.org/D5172
AFFECTED FILES
plugins/qpa/screen.cpp
pl
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Apart from the two minor issues, looks good to me :)
INLINE COMMENTS
> markg wrote in screen.cpp:79
> c cast... no no no!
> static_cast(...)
is the cast needed at all? It should be i
markg added inline comments.
INLINE COMMENTS
> screen.cpp:25
> #include
> +#include
>
Looks like its unused.
> screen.cpp:79
> +{
> +return = m_output ? (qreal)m_output->scale() : 1.0;
> +}
c cast... no no no!
static_cast(...)
REVISION DETAIL
https://phabricator.kde.org/D5172
To:
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Basically just a copy and paste from the relevant Qt Wayland parts.
BRANCH
scaling_final
REVISION DETAIL
https://phabricator.kde.o
