This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d6121f3f5c25: [desktop:/ KIO] Add descriptive name for
root item (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5221?vs=12946=13115
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5221
To: broulik, #plasma, hein, elvisangelaccio, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
broulik edited the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5221
To: broulik, #plasma, hein, elvisangelaccio, dfaure
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol
broulik updated this revision to Diff 12946.
broulik added a comment.
- Check for requested url path being "/"
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5221?vs=12919=12946
REVISION DETAIL
https://phabricator.kde.org/D5221
AFFECTED FILES
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kio_desktop.cpp:171
> +// Set a descriptive display name for the root item
> +if (entry.stringValue(KIO::UDSEntry::UDS_NAME) == QLatin1String(".")) {
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5221
To: broulik, #plasma, hein, dfaure, elvisangelaccio
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This way Folder View could use the root item for its heading instead of
special-casing it for desktop:/
TEST PLAN
I should probably check
