This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1eb950a98514: Desaturate non-responsive windows (authored
by broulik).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5245?vs=12992&id=13104
REVISION DETAIL
https:/
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
Let's bring it in! We can still adjust the visual aspects after merging.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5245
To: broulik, #vdg, graesslin, #kwi
fredrik added a comment.
In https://phabricator.kde.org/D5245#98926, @broulik wrote:
> > Lower brightness?
>
> I actually increase the brightness to produce this washed-out effect but
admittedly it doesn't look as good in less graphically intensive apps (I used
Gwenview in the screen
broulik updated this revision to Diff 12992.
broulik edited the test plan for this revision.
broulik added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Base frozenapp effect on dialogparent code, this fixes minimizing of frozen
windows and also switching des
broulik marked 2 inline comments as done.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D5245
To: broulik, #plasma, #kwin, #vdg, graesslin
Cc: luebking, kvermette, graesslin, plasma-devel, kwin, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol
broulik added a comment.
> Lower brightness?
I actually increase the brightness to produce this washed-out effect but
admittedly it doesn't look as good in less graphically intensive apps (I used
Gwenview in the screenshot where you can tell easily but in Kwrite you probably
can't). I'l
luebking added a comment.
In https://phabricator.kde.org/D5245#98917, @graesslin wrote:
> This is something we do not know. We do not know what color scheme the
window uses. Given that a desaturation is probably the best we can do.
Lower brightness?
REPOSITORY
R108 KWin
REVISI
graesslin added a comment.
In https://phabricator.kde.org/D5245#98866, @kvermette wrote:
> My only concern is that many windows with the Breeze style have very little
colour, some (like Kate) might not see the effect be distinguishable at all.
Should we perhaps consider using an overlay
kvermette added a comment.
My only concern is that many windows with the Breeze style have very little
colour, some (like Kate) might not see the effect be distinguishable at all.
Should we perhaps consider using an overlay colour selected from the colour
scheme which we know will stand out?
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please adjust the autotests/test_*_effectloader.cpp - they would fail as you
added an effect. Also please try running all autotests, we have some tests for
the kill timeout,
broulik updated this revision to Diff 12983.
broulik added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Fix couple of typos and remove debug
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5245?vs=12981&id=12983
REVISION DET
broulik created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
When an application is not responding, its window is desaturated to
communicate this. Also "(Not Responding)" is added to the title bar.
T
12 matches
Mail list logo
