D5339: Include a bottom toolbar for the application page

2017-04-11 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R134:650eb5ccbeb5: Include a bottom toolbar for the application page (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D5339?vs=13323=13324#toc REPOSITORY R134 Discover Software

D5339: Include a bottom toolbar for the application page

2017-04-11 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 13323. apol added a comment. Adopt changes as suggested by Jens REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5339?vs=13207=13323 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5339

D5339: Include a bottom toolbar for the application page

2017-04-08 Thread Jens Reuterberg
jensreuterberg added a comment. I think both are good (but man those colours Aleix :D also the text should be white) The logic behind the alternatives for posterity: 1. Buttons on bottom of Detail view - the install button in the detail view is there for those who will want to read

D5339: Include a bottom toolbar for the application page

2017-04-08 Thread Thomas Pfeiffer
colomar added a comment. Version 2 (top toolbar, no colors) looks the best to me, with the downside that the install button does not stick out. If we go without colors, we'd probably at least need an icon for the install button to not make it totally blend with the rest. REPOSITORY R134

D5339: Include a bottom toolbar for the application page

2017-04-07 Thread Aleix Pol Gonzalez
apol added a comment. On top, with tool buttons: F3553099: Spectacle.M28707.png Crazy colored buttons (as per jens request, the colors were obviously chosen by me though in hope for feedback): F3553122: Spectacle.M30591.png

D5339: Include a bottom toolbar for the application page

2017-04-07 Thread Aleix Pol Gonzalez
apol added a comment. Proof F3552090: Spectacle.Hx7882.png REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5339 To: apol, leinir, colomar, jensreuterberg Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

D5339: Include a bottom toolbar for the application page

2017-04-07 Thread Aleix Pol Gonzalez
apol added reviewers: colomar, jensreuterberg. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5339 To: apol, leinir, colomar, jensreuterberg Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5339: Include a bottom toolbar for the application page

2017-04-07 Thread Aleix Pol Gonzalez
apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY After a chat with Jens, we decided to introduce this toolbar. We've wanted to have a back button for a while and we never liked the floaty