markg added a comment.
I'm just curious. Why is the day name determined in QML (in the lines you
edited, but was there before as well) and on the C++ side?
It smells like a redundancy.
As far as i can tell (only looked for a moment), the dayName on the C++ side
isn't used "in" the C++
drosca added inline comments.
INLINE COMMENTS
> mck182 wrote in DaysCalendar.qml:315
> Now I'm not entirely sure but can the `uiLanguages[0]`
> possibly return null?
It's used exactly the same on the C++ side (without the bounds check), so I
assume it's safe as that code is now over 2 years
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a01e4fb69efe: Calendar: Use correct language for month
and day names (authored by drosca).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.
...provided the usage of `uiLanguages[0]` is safe like this.
INLINE COMMENTS
> DaysCalendar.qml:315
> height: daysCalendar.cellHeight
> -text:
drosca created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Apply fix for bug 353715 also on QML side.
TEST PLAN
I have English ui language + Czech time format. Months and days
