D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-27 Thread Tobias C. Berner
tcberner retitled this revision from "Include signal.h for kill(), and prototype kqueue/kevent stuff..." to "kcheckpass: Add support in for non-Linux platforms via kevent.". tcberner edited the summary of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.o

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-29 Thread Tobias C. Berner
tcberner added a reviewer: kde-mac. tcberner marked 2 inline comments as done. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5825 To: tcberner, #freebsd, graesslin, kde-mac Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mo

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-29 Thread René J . V . Bertin
rjvbb added a comment. In https://phabricator.kde.org/D5825#109698, @tcberner wrote: > I have not yet had time to test it at all :) Do you actually intend to test this on Mac? I laud and applaud the initiative but I see only one way that the package will ever get used on Mac - pro

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-29 Thread Tobias C. Berner
tcberner edited the summary of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5825 To: tcberner, #freebsd, graesslin, kde-mac Cc: rjvbb, adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abe

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-29 Thread Tobias C. Berner
tcberner added a comment. > Do you actually intend to test this on Mac? Nope, I don't have a Mac :) -- but I hoped, that there were some Mac users who could check it on their end too (as you also have kqueue/kevent) -- but I did not know that most of the stuff is not yet ported for Mac.

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-29 Thread René J . V . Bertin
rjvbb added a comment. In https://phabricator.kde.org/D5825#112442, @tcberner wrote: > > Do you actually intend to test this on Mac? > > Nope, I don't have a Mac :) -- but I hoped, that there were some Mac users who could check it on their end too (as you also have kqueue/kevent) -- b

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-29 Thread René J . V . Bertin
rjvbb added a comment. Already getting updates through kde-mac, no need to receive everything twice. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5825 To: tcberner, #freebsd, graesslin, kde-mac Cc: adridg, davidedmundson, plasma-devel, ZrenBot, spstarr, prog

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-29 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. OS X is not a supported Plasma platform, BSD is. Whether it works there or not too important. You can put this in the 5.10 branch for 5.10.1 which is out pretty soon aft

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-29 Thread Tobias C. Berner
This revision was automatically updated to reflect the committed changes. Closed by commit R133:c2fd8526c523: kcheckpass: Add support in for non-Linux platforms via kevent. (authored by tcberner). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5825?vs=14

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-05-29 Thread René J . V . Bertin
rjvbb added a comment. In https://phabricator.kde.org/D5825#112464, @davidedmundson wrote: > OS X is not a supported Plasma platform, BSD is. Just for future reference: OS X doesn't have sigwaitinfo() (or the cited alternative). REPOSITORY R133 KScreenLocker REVISION DETAIL

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-06-14 Thread Martin Flöser
graesslin added a subscriber: rjvbb. graesslin added a comment. In https://phabricator.kde.org/D5825#112682, @rjvbb wrote: > In https://phabricator.kde.org/D5825#112464, @davidedmundson wrote: > > > OS X is not a supported Plasma platform, BSD is. > > > Just for future reference:

D5825: kcheckpass: Add support in for non-Linux platforms via kevent.

2017-06-14 Thread René J . V . Bertin
rjvbb added a comment. > Nevertheless OS X is not supported by kscreenlocker and will never be. You got it all wrong, OS X doesn't support kscreenlocking, gna! (If I were still a fanboy I'd add that it's way too kool to support running most kinds of plasma O:^) ) REPOSITORY R133