D6047: WIP: Support XDG v6

2017-06-27 Thread David Edmundson
davidedmundson added a comment. Update from IRC chat: It was BIC from when I renamed that signal. All resolved. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff,

D6047: WIP: Support XDG v6

2017-06-27 Thread Marco Martin
mart added a comment. right now, the xdgv6 branch (xdgv6popup actually) for me causes a crash in kwin at startup, with the following BT: #0 _int_malloc (av=av@entry=0x7556ab20 , bytes=bytes@entry=72) at malloc.c:3414 #1 0x7522a5d4 in __GI___libc_malloc (bytes=72) at

D6047: WIP: Support XDG v6

2017-06-27 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6047#119765, @graesslin wrote: > In https://phabricator.kde.org/D6047#119698, @mart wrote: > > > trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 > > > no need to hurry with it.

D6047: WIP: Support XDG v6

2017-06-26 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D6047#119698, @mart wrote: > trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 no need to hurry with it. IMHO the way ping works is completely broken and won't work. At least Qt

D6047: WIP: Support XDG v6

2017-06-26 Thread David Edmundson
davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Done all comments except ping/pong. Marco, ping me if you ever want this updating. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin,

D6047: WIP: Support XDG v6

2017-06-26 Thread David Edmundson
davidedmundson updated this revision to Diff 15889. davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. - cleanups REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D6047: WIP: Support XDG v6

2017-06-26 Thread Marco Martin
mart added a comment. trying to implement the kwin part of ping btw, will do in a branch of the branch kwin/xdgv6 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: graesslin, mart, plasma-devel, #frameworks, ZrenBot, progwolff,

D6047: WIP: Support XDG v6

2017-06-23 Thread David Edmundson
davidedmundson updated this revision to Diff 15797. davidedmundson edited the summary of this revision. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Try to upload via arc... REPOSITORY R127 KWayland CHANGES SINCE LAST

D6047: WIP: Support XDG v6

2017-06-23 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > graesslin wrote in xdgshell_interface.h:80 > @davidedmundson for the ping you could check the old wl_shell_surface > implementation in KWayland. the implementation here in xdgshell_interface is basically copied over the kwayland

D6047: WIP: Support XDG v6

2017-06-22 Thread Martin Flöser
graesslin added a comment. could you please upload a version with context? INLINE COMMENTS > mart wrote in xdgshell_interface.h:80 > from kwin, client.cpp: > i guess that's the kwin part that will have to use this. > it uses a single timer, and tries for a couple of timeout, as soon as the

D6047: WIP: Support XDG v6

2017-06-20 Thread David Edmundson
davidedmundson updated this revision to Diff 15634. davidedmundson edited the summary of this revision. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=15020=15634 REVISION DETAIL https://phabricator.kde.org/D6047 AFFECTED FILES autotests/client/CMakeLists.txt

D6047: WIP: Support XDG v6

2017-06-05 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > mart wrote in xdgshell_interface.h:80 > so storing all the ids of pings in progress somewhere to make a more recent > ping not cancel an older one still pending? from kwin, client.cpp: i guess that's the kwin part that will have to use this. it

D6047: WIP: Support XDG v6

2017-06-01 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in xdgshell_interface.h:80 > We need the serial Ids here, otherwise it's not very usable; especially as > the pong doesn't have an elapsed time. > > A kjob like API wrapping this might be perfect for here? so storing all the

D6047: WIP: Support XDG v6

2017-06-01 Thread David Edmundson
davidedmundson added a comment. Comments for Marco: INLINE COMMENTS > xdgshell_interface.h:80 > > +void ping(); > + We need the serial Ids here, otherwise it's not very usable; especially as the pong doesn't have an elapsed time. A kjob like API wrapping this might be perfect for

D6047: WIP: Support XDG v6

2017-05-31 Thread David Edmundson
davidedmundson updated this revision to Diff 15020. davidedmundson added a comment. Arc didn't work, I think it was too big. Manually uploading the patch did. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6047?vs=15013=15020 REVISION DETAIL https://phabricator.kde.org/D6047

D6047: WIP: Support XDG v6

2017-05-31 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. Flipping phabricator... REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D6047 To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,

D6047: WIP: Support XDG v6

2017-05-31 Thread David Edmundson
davidedmundson created this revision. davidedmundson added projects: Plasma on Wayland, Frameworks. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REVISION SUMMARY To move forward faster I thought we could start reviewing the davidedmundson/xdgv6 branch for