D6056: [Run Command] Auto-close on focus loss only if query field is empty

2020-03-28 Thread Robert Barat
rwbarat added a comment. Hey @ngraham @davidedmundson @broulik I was wondering if there are any updates on this patch, as closing when losing focus is a frequent issue for me with KRunner a bunch of other people too according to the Bugzilla issue page for this

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2019-12-05 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Actually I see a problem with this now that I try it out again: if you switch away from Krunner while it's still open with input and then trigger it again, a second one opens!

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2019-09-28 Thread Björn Feber
GB_2 added a comment. Is there a reason this isn't landed yet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: GB_2, elcste, shubham, ngraham, cfeck, anthonyfieroni, plasma-devel, LeGast00n,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2018-12-24 Thread Shubham
shubham added a comment. Year and half old patch, lucky it got noticed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: shubham, ngraham, cfeck, anthonyfieroni, plasma-devel, GB_2, ragreen,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2018-12-24 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This works great for me and fixes an annoying bug. Can we get it landed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson, ngraham Cc: ngraham, cfeck,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2018-10-13 Thread Christoph Feck
cfeck added a comment. Please commit or abandon this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson Cc: cfeck, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2017-09-28 Thread Christoph Feck
cfeck added a comment. What is the status of this patch? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson Cc: cfeck, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2017-06-05 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg, davidedmundson Cc: anthonyfieroni, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2017-06-01 Thread Anthony Fieroni
anthonyfieroni added a comment. Does it better to do it like in yakuake https://cgit.kde.org/yakuake.git/tree/app/mainwindow.cpp#n1059 ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D6056 To: broulik, #plasma, #vdg Cc: anthonyfieroni, plasma-devel,

D6056: [Run Command] Auto-close on focus loss only if query field is empty

2017-06-01 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If the user didn't accept any search result or didn't explicitly close it, he or she might still want to tweak the query, e.g. when summing