D6061: prototype of kactivity-based most used modules entries

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY use kactivities to track the most used modules (kcmshell will need to as well) and present them in the start page as 5 big icons TEST PLAN em

D6061: prototype of kactivity-based most used modules entries

mart added a comment. first page look as per vdg suggestion F3773242: Spectacle.y10298.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D6061 To: mart, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezha

D6061: prototype of kactivity-based most used modules entries

mart added a reviewer: VDG. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D6061 To: mart, #plasma, #vdg Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6061: prototype of kactivity-based most used modules entries

abetts added a comment. In https://phabricator.kde.org/D6061#113477, @mart wrote: > first page look as per vdg suggestion > F3773242: Spectacle.y10298.png I would like to suggest making the system settings icon 512 and the row of 5 icons 2

D6061: prototype of kactivity-based most used modules entries

mart added a comment. In https://phabricator.kde.org/D6061#113481, @abetts wrote: > In https://phabricator.kde.org/D6061#113477, @mart wrote: > > > first page look as per vdg suggestion > > F3773242: Spectacle.y10298.png > > > I would lik

D6061: prototype of kactivity-based most used modules entries

mart updated this revision to Diff 15056. mart added a comment. - more icon spacing REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6061?vs=15055&id=15056 BRANCH mart/mostUsedModules REVISION DETAIL https://phabricator.kde.org/D6061 AFFECTED F

D6061: prototype of kactivity-based most used modules entries

mart added a comment. more spacing, icons still small, wouldn't go much bigger than that F3773262: Spectacle.L12141.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D6061 To: mart, #plasma, #vdg Cc: abetts, plasma-dev

D6061: prototype of kactivity-based most used modules entries

davidedmundson added inline comments. INLINE COMMENTS > ModuleView.cpp:349 > +if (activeModule) { > +KActivities::ResourceInstance::notifyAccessed(QUrl("kcm:" + > activeModule->moduleInfo().service()->storageId()), > +"org.kde.systemsettings"); not "kcm:/" ? > Sideb

D6061: prototype of kactivity-based most used modules entries

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in ModuleView.cpp:349 > not "kcm:/" ? i seen that kicker does application:desktopfile.desktop so i did the same, but is the same in the end > davidedmundson wrote in SidebarMode.cpp:133 > Can I propose an alternative: > > At t

D6061: prototype of kactivity-based most used modules entries

mart updated this revision to Diff 15071. mart added a comment. - don't create services when it's not needed REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6061?vs=15056&id=15071 BRANCH mart/mostUsedModules REVISION DETAIL https://phabricator.

D6061: prototype of kactivity-based most used modules entries

mart marked an inline comment as done. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D6061 To: mart, #plasma, #vdg Cc: davidedmundson, abetts, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, lukas

D6061: prototype of kactivity-based most used modules entries

This revision was automatically updated to reflect the committed changes. Closed by commit R124:1018b86e48db: prototype of kactivity-based most used modules entries (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6061?vs=15071&id=15199#toc REPOSITORY R124 System Sett

D6061: prototype of kactivity-based most used modules entries

davidedmundson added a comment. Make sure you test with --reverse too INLINE COMMENTS > mart wrote in SidebarMode.cpp:163 > I need to remove the kcm: part Right, but I meant don't call sourceModel()->data(mapToSource) when you can just call the superclasses data method. > IntroIcon.qml

D6061: prototype of kactivity-based most used modules entries

mart marked 2 inline comments as done. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D6061 To: mart, #plasma, #vdg Cc: davidedmundson, abetts, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, lukas