This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d821bffe1948: [Icon Applet] Get favicon for website
shortcuts (authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6163?vs=15309&id=22879
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6163
To: broulik, #plasma, dfaure
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol,
dfaure added a comment.
Yeah the favicon for kde.org is bigger than the size limit from the kio code
-- ironic, isn't it. I never took the time to find out if it could be reduced,
or if the size limit should be increased, and whatever other websites and other
webbrowsers do.
As for KIO:
broulik edited the test plan for this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D6163
To: broulik, #plasma, dfaure
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When creating an icon for a website use its favicon if possible.
TEST PLAN
It fails to get the favicon for kde.org but succeeds with other w