D6214: check window visibility at expose event

2017-06-15 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R135:7ace568d2374: check window visibility at expose event (authored by mart). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6214?vs=1

D6214: check window visibility at expose event

2017-06-13 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6214#116242, @davidedmundson wrote: > Edit. > > qwaylandwindow code is: > > if (! (mShellSurface && mShellSurface->handleExpose(rect))) > QWindowSystemInterface::handleExposeEvent(window(), rect); > > > so if

D6214: check window visibility at expose event

2017-06-13 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Edit. qwaylandwindow code is: if (! (mShellSurface && mShellSurface->handleExpose(rect))) QWindowSystemInterface::handleExposeEvent(window(), rect);

D6214: check window visibility at expose event

2017-06-13 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D6214#116240, @davidedmundson wrote: > > it's possible that a window gets an expose event even if the qwindow > > is not visible > > How? > > QWaylandXdgSurfaceV6::handleExpose returns false if it's not configured yet, and w

D6214: check window visibility at expose event

2017-06-13 Thread David Edmundson
davidedmundson added a comment. > it's possible that a window gets an expose event even if the qwindow is not visible How? QWaylandXdgSurfaceV6::handleExpose returns false if it's not configured yet, and we can't receive a configure before we've created the shell, and we don't

D6214: check window visibility at expose event

2017-06-13 Thread Marco Martin
mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it's possible that a window gets an expose event even if the qwindow is not visible, this can cause problems like the window decoration create