This revision was automatically updated to reflect the committed changes.
Closed by commit R119:84300b516b79: Fix DND onto Task Manager for groups, group
dialog scrollbar (authored by hein).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6231?vs=15485=15572#toc
REPOSITORY
R119 Plasma
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D6231
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
hein updated this revision to Diff 15485.
hein added a comment.
One more readonly; I'm out of stuff now.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6231?vs=15484=15485
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D6231
hein updated this revision to Diff 15484.
hein added a comment.
Waiting for David leads to more small cleanups.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6231?vs=15483=15484
BRANCH
Plasma/5.8
REVISION DETAIL
hein requested review of this revision.
hein added a comment.
David, you still ok with this updated rev? Sorry, was working in parallel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6231
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr,
hein updated this revision to Diff 15483.
hein added a comment.
Properly make room for scrollbar if needed.
This was kinda-sorta intended to be there (see contentWidth) but
somehow got lost during development.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D6231
To: hein, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai,
hein updated this revision to Diff 15482.
hein added a comment.
Set aboutToPopulate always, and before setting the rootIndex.
Fixes pre-selecting the active window when moving the dialog
from one group to another during drag hover.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST
hein updated this revision to Diff 15481.
hein added a comment.
Slightly simpler + better comment.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6231?vs=15480=15481
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D6231
AFFECTED
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
With this patch drag-hover activation will work for group children,
and moving between different group parents while dragging will
correctly refresh the dialog contents.
BUG:379888
The patch
10 matches
Mail list logo