mart abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart,
mart added a comment.
replaced by https://phabricator.kde.org/D6523
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
To: mart, #plasma
Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot,
progwolff, lesliezhai, ali-mohamed,
davidedmundson added a comment.
Buffer::Ptr ShmPool::createBuffer(const QImage& image)
{
if (image.isNull() || !d->valid) {
return QWeakPointer();
}
...
if our image is null (which it is), we get an an invalid Buffer::Ptr
Shadow::attach expects that to be val
mart added a comment.
In https://phabricator.kde.org/D6518#121981, @davidedmundson wrote:
> What if a theme only has shadow-top, but not right etc.
> (or a more likely scenario, they exist, but the metadata has them be 0px
big)
>
> What would happen if you have a theme with shadow
anthonyfieroni added inline comments.
INLINE COMMENTS
> dialogshadows.cpp:270
> {
> m_shadowPixmaps << q->pixmap(element);
> }
Validate element (hasElement and > 0) or add default pixmap.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
T
davidedmundson added a comment.
What if a theme only has shadow-top, but not right etc.
(or a more likely scenario, they exist, but the metadata has them be 0px big)
What would happen if you have a theme with shadow then switch to one without?
REPOSITORY
R242 Plasma Framework (Library
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
some themes don't have a valid shadow, which would lead
to a crash in kwayland, don't even try to render a shadow
if one