D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open

2017-07-07 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f3dcff28b8fb: [Containment Interface] Keep containment in RequiresAttentionStatus while… (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabric

D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open

2017-07-06 Thread Marco Martin
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > broulik wrote in containmentinterface.cpp:1073 > Not sure if we should use `this` (and then check `if m_containment` as > context or `m_containment` should be the same RE

D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open

2017-07-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > containmentinterface.cpp:1073 > + > +connect(desktopMenu, &QMenu::aboutToHide, m_containment, [this, > oldStatus] { > +m_containment->setStatus(oldStatus); Not sure if we should use `this` (and then check `if m_containment` as context

D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open

2017-07-06 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This ensures the panel does not auto-hide then. It also forces a re-evaluation of auto-hide status when the menu closes