This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b669d4148a39: Destroy all kwayland objects created by
registry when it is destroyed (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
davidedmundson/xdgv6
REVISION DETAIL
https://phabricator.kde.org/D6727
To: davidedmundson, graesslin
Cc: graesslin, plasma-devel, #frameworks, leezu, ZrenBot, progwolff,
davidedmundson updated this revision to Diff 17272.
davidedmundson added a comment.
Updated docs + unit test
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6727?vs=16758=17272
BRANCH
davidedmundson/xdgv6
REVISION DETAIL
graesslin added a comment.
In https://phabricator.kde.org/D6727#125900, @davidedmundson wrote:
> We still need https://phabricator.kde.org/D6571, with my proposed change.
That's a special case where we delete the connection before the QPA.
It might be that we don't need it. Also
davidedmundson added a comment.
We still need https://phabricator.kde.org/D6571, with my proposed change.
That's a special case where we delete the connection before the QPA.
My added connect means that we get that signal regardless of whether we're in
Kwin or not.
What we wouldn't
graesslin added a comment.
I like the idea! That would basically allow us to abandon
https://phabricator.kde.org/D6571 and would also solve the issues we see with
the kwayland-integration plugin which can crash applications on exit.
May I ask for a small unit test for the new
davidedmundson created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
Currently one has to connect every object manually to connectionDied,
which is something we can do
