ngraham added a comment.
@guoyunhe, Nice! In the future can you use the `arc land` instead of
committing manually? That way all the history and details in the Summary here
gets added to the commit, and we have a better paper trail. Thanks!
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
guoyunhe closed this revision.
guoyunhe added a comment.
This patch has been committed to master branch. I will add the
color/blur-image radio buttons in another patch.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7047
To: guoyunhe, #plasma_workspaces, n
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Personally I approve, in and of itself the feature looks fine. I think we
should consider the UI though, as adding more background effects exacerbates an
existing problem. But I won't ove
guoyunhe added a comment.
In https://phabricator.kde.org/D7047#158496, @ngraham wrote:
> It occurs to me that only the "Scaled, Keep Proportions" and "Centered"
positioning modes require any kind of background effect or color. With other
positioning modes, the existing Background Color c
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
It occurs to me that only the "Scaled, Keep Proportions" and "Centered"
positioning modes require any kind of background effect or color. With other
positioning modes, the exist
guoyunhe updated this revision to Diff 17538.
guoyunhe marked an inline comment as done.
guoyunhe added a comment.
Improve image transition animation. Image transition and blur background
transition are now synchronous and smooth.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
guoyunhe marked 2 inline comments as done.
guoyunhe added inline comments.
INLINE COMMENTS
> broulik wrote in main.qml:213
> Is it possible to re-use the currentImage instead of creating yet another
> `Image` item? I know with `ShaderEffect` you can do `hideSource: false` but I
> don't see this
guoyunhe updated this revision to Diff 17518.
guoyunhe added a comment.
Solve some coding issue. Use two GaussianBlur to keep sync with image
slideshow.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7047?vs=17517&id=17518
REVISION DETAIL
https
broulik added a comment.
Pretty cool idea!
INLINE COMMENTS
> WallpaperDelegate.qml:73
> +
> +GaussianBlur {
> +visible: cfg_Blur
I think for the preview a `FastBlur` is sufficient, or perhaps even just
scaling up a tiny pixmap
> config.qml:142
> +id:
guoyunhe created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Add a checkbox to wallpaper configuration dialog. By checking this option,
empty space surround image will be filled by blurred image rather
10 matches
Mail list logo
