davidedmundson added a comment.
> This change *is* a fix for the blurry icon which accidentally improves the
config UI ;-)
Well not really, for absolute paths you're just avoding a bug in IconItem.
See https://bugs.kde.org/show_bug.cgi?id=383513
REPOSITORY
R119 Plasma Desktop
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b46cd1ed167c: Use icon chooser in Kicker and Dashboard
configuration to select custom icon (authored by dvratil).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
hein accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7469
To: dvratil, #plasma, hein
Cc: hein, davidedmundson, broulik, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed,
dvratil added a comment.
> BTW this change will also accidentally fix your blurry icon issue you
showed me at Akademy.
This change **is** a fix for the blurry icon which accidentally improves the
config UI ;-)
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
dvratil updated this revision to Diff 18635.
dvratil added a comment.
Fix fallback to cfg_icon instead of hardcoded start-here-kde.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7469?vs=18562=18635
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> hein wrote in ConfigGeneral.qml:123
> This isn't OK - it needs to revert to the actual config default. Some distros
> change it to their branded icon and are very keen on wanting to override
> specifically the default rather than pre-setting a
davidedmundson added a comment.
> @davidedmundson As Kai Uwe said, this is basically just copy-pasted from
KickOff configuration code - do you still want me to change it to 1.x control?
No, if Kai says something is fine, it's probably fine.
BTW this change will also accidentally fix
hein added a comment.
Can you also check the following case:
1. Use the old UI to
INLINE COMMENTS
> ConfigGeneral.qml:123
> +cfg_useCustomButtonImage = false;
> +cfg_icon = "start-here-kde";
> +}
This isn't OK - it
dvratil added a comment.
@hein Tested that, you can still choose an arbitrary image file in the
filesystem through the dialog and the image is used correctly
@davidedmundson As Kai Uwe said, this is basically just copy-pasted from
KickOff configuration code - do you still want me to change
hein added a comment.
This was done intentionally in the past to allow people to pick random images
and get the proper kind of URL back to feed into the Image (which isn't used
anymore). Can you verify this workflow still works?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in ConfigGeneral.qml:26
> this shouldn't be used in a config module.
>
> Use QtQuick.Controls 1.x instead
That's fine. Fwict this code is from Kickoff and there we have a QQC Button for
the icon which inside has a Plasma
davidedmundson added inline comments.
INLINE COMMENTS
> ConfigGeneral.qml:26
> +import org.kde.plasma.core 2.0 as PlasmaCore
> +import org.kde.plasma.components 2.0 as PlasmaComponents
> +
this shouldn't be used in a config module.
Use QtQuick.Controls 1.x instead
REPOSITORY
R119 Plasma
broulik added a comment.
+1 from me
One can also choose a custom icon from file system in the icon dialog
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7469
To: dvratil, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
dvratil created this revision.
dvratil added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Use KQuickAddons.IconDialog to choose a custom icon for the applet instead of
just a plain old open file dialog with extension filter. This makes it
14 matches
Mail list logo
