D7629: Do not show reveal password button on login screen

romangg closed this revision. romangg added a comment. Superseded by D9040 . REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7629 To: siteshwarv, #plasma_workspaces, davidedmundson Cc: romangg, rdieter, ngraham, mart, david

D7629: Do not show reveal password button on login screen

rdieter added a comment. If you're going to do this, may as well undo all of https://phabricator.kde.org/D3616 , and remove the reveal password button from the lockscreen too ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7629 To: siteshwarv, #plasma_wo

D7629: Do not show reveal password button on login screen

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. We also have bug 387418. And we don't have kiosk restrictions in SDDM either. Given the rationale for introducing it was very thin, in the first place. I'm going to merg

D7629: Do not show reveal password button on login screen

siteshwarv added a comment. gentoo REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7629 To: siteshwarv, #plasma_workspaces Cc: mart, davidedmundson, rharishnavnit, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apo

D7629: Do not show reveal password button on login screen

davidedmundson added a comment. What distro? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7629 To: siteshwarv, #plasma_workspaces Cc: mart, davidedmundson, rharishnavnit, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D7629: Do not show reveal password button on login screen

siteshwarv added a comment. I have talked to other people who use sddm on other distros where eye icon is visible. Despite of the eye icon being visible in the password box, people accidentally click it and it takes some time before they realize it. I would prefer to remove it from the login

D7629: Do not show reveal password button on login screen

mart added a comment. -1 as well, icon should be fixed REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7629 To: siteshwarv, #plasma_workspaces Cc: mart, davidedmundson, rharishnavnit, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D7629: Do not show reveal password button on login screen

davidedmundson added a comment. So the killer issue from your bug report is that there's no "eye" icon in your SDDM login. That definitely is a big problem and needs a solution. But just removing the setting isn't really trying to address the actual bug at all, it's just avoiding it. RE

D7629: Do not show reveal password button on login screen

rharishnavnit added a comment. Personally, I believe that the reveal password feature should stay. There's an eye icon shown in the password field too IIRC(just checked my lock screen) and I'm puzzled how that can be confusing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://ph

D7629: Do not show reveal password button on login screen

siteshwarv created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Reveal password button on the login screen is unnecessary. It can be clicked accidentally and is confusing to the users. Related bug https