D7794: create the whole plugin structure in the build directory

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY when building copy all qml files in build/org/kde/kirigami.2 as well generating the binary plugin there. this is neccessary to be able to lo

D7794: create the whole plugin structure in the build directory

mart updated this revision to Diff 19473. mart added a comment. - alternative approach REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19472&id=19473 BRANCH cmakehack REVISION DETAIL https://phabricator.kde.org/D7794 AFFECTED FILES src/CMak

D7794: create the whole plugin structure in the build directory

apol added a comment. Also you maybe can move this code into the tests subdirectory, so it only needs to be run in `BUILD_TESTING`. I am not sure if this is going to work but I agree that if it has any opportunity then it's probably along these lines... INLINE COMMENTS > CMakeLists.txt

D7794: create the whole plugin structure in the build directory

mart added a comment. In https://phabricator.kde.org/D7794#145371, @apol wrote: > Also you maybe can move this code into the tests subdirectory, so it only needs to be run in `BUILD_TESTING`. > > I am not sure if this is going to work but I agree that if it has any opportunity then i

D7794: create the whole plugin structure in the build directory

mart added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:33 > Why do you need to GLOB? can't you just copy the whole directory over with > all of the styles/controls inside? if instead of the GLOB i put in the copy command directly the directory name, it seems to not actually

D7794: create the whole plugin structure in the build directory

mart updated this revision to Diff 19636. mart added a comment. - get rid of GLOB REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19473&id=19636 BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 AFFECTED FILES src/CMak

D7794: create the whole plugin structure in the build directory

mart updated this revision to Diff 19637. mart added a comment. - remove dead code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19636&id=19637 BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 AFFECTED FILES src/CMa

D7794: create the whole plugin structure in the build directory

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R169 Kirigami BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 To: mart, #kirigami, dfaure, sitter, apol Cc: apol, plasma-devel, mart

D7794: create the whole plugin structure in the build directory

mart updated this revision to Diff 19638. mart added a comment. - lowercase REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19637&id=19638 BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 AFFECTED FILES src/CMakeLists

D7794: create the whole plugin structure in the build directory

apol accepted this revision. REPOSITORY R169 Kirigami BRANCH arcpatch-D7794 REVISION DETAIL https://phabricator.kde.org/D7794 To: mart, #kirigami, dfaure, sitter, apol Cc: apol, plasma-devel, mart, hein

D7794: create the whole plugin structure in the build directory

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c90968f1f8dc: create the whole plugin structure in the build directory (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7794?vs=19638&id=19639 R