davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
Similar to the Blur patch. Arguably rven less reason as this doesn't
have a texture
graesslin added inline comments.
INLINE COMMENTS
> contrast.cpp:79
> +}
> +foreach (EffectWindow *window, effects->stackingOrder())
> +updateContrastRegion(window);
please no foreach in new code, please use range-based for. (Reason: I don't
trust Qt to keep it after there was a
davidedmundson updated this revision to Diff 19791.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
for
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7937?vs=19788&id=19791
BRANCH
master
REVISION DETAIL
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7937
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai,
ali-moh
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:55d219429a54: Don't reload background contrast
effect on screen resize (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7937?vs=19791&id=20
