D7957: Turn on frames around dock widgets by default

jensreuterberg added a comment. I would avoid the shadows personally - it would be better to focus on better spacing between the two areas and a clearer font usage to define them. Like Broulik mentions it was removed more or less by active choice REPOSITORY R31 Breeze REVISION DETAIL

D7957: Turn on frames around dock widgets by default

abetts added a comment. In https://phabricator.kde.org/D7957#161647, @ngraham wrote: > The shadow seems a bit gratuitous to me, but I have to say I do like the extra borders and the nice explicit separator between Panels. Maybe another idea, instead of shadows is changing the

D7957: Turn on frames around dock widgets by default

ngraham added a comment. The shadow seems a bit gratuitous to me, but I have to say I do like the extra borders and the nice explicit separator between Panels. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: abetts, broulik,

D7957: Turn on frames around dock widgets by default

abetts added a comment. I would even go as far as doing this: F5457461: Shadows.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: abetts, broulik, emmanuelp, elvisangelaccio,

D7957: Turn on frames around dock widgets by default

ngraham abandoned this revision. ngraham added a comment. Too hard, can't figure it out. Maybe I'll revisit this at another time. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella,

D7957: Turn on frames around dock widgets by default

ngraham planned changes to this revision. ngraham added a comment. I'll see if I can re-work the patch to add separators when frames are off, rather than turning on all frames by default. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg

D7957: Turn on frames around dock widgets by default

ngraham added a comment. As a 24 year Mac refugee, I agree with you that Finder's Tags implementation is excellent, and I think we should copy it. But the macOS Finder approach (everything scrollable in the same sidebar) is what was rejected in https://phabricator.kde.org/D7700. But getting

D7957: Turn on frames around dock widgets by default

markg added a comment. Watch this: https://www.youtube.com/watch?v=T0Jj4lUm_p8 Apple really has done a marvelous job in making tags useful! Anyhow, we can learn a couple things from there implementation of the sidebar. 1. It doesn't scroll "per panel", it scrolls for the whole

D7957: Turn on frames around dock widgets by default

ngraham added a comment. As I am pointing out, without frames the splitter is invisible, which is a clear usability issue. It also presents an aesthetic issue since when content on either side of the splitter is cut off, it looks like a visual glitch: F3923285: Cut off for no clear

D7957: Turn on frames around dock widgets by default

markg added a comment. -1 for the current version as well. We've had those frames before. The benefit of locking docks is no frame (for me that is the benefit). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp,

D7957: Turn on frames around dock widgets by default

ngraham edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7957: Turn on frames around dock widgets by default

ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D7957 To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp, elvisangelaccio, nicolasfella, markg, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7957: Turn on frames around dock widgets by default

ngraham updated this revision to Diff 19839. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7957?vs=19836=19839 REVISION DETAIL https://phabricator.kde.org/D7957 AFFECTED FILES kstyle/breeze.kcfg To: ngraham, #breeze, #vdg Cc: broulik, emmanuelp,

D7957: Turn on frames around dock widgets by default

ngraham retitled this revision from "Turn on frames around dock widgets and side panels by default" to "Turn on frames around dock widgets by default". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze REVISION DETAIL