davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in desktopview.cpp:60
> Is it correct to compare to software? What if vulkan get's introduced?
Then we change it..
The reason it's done this way round is currently is that
setSceneGraph("aaerkwlakrjaldkfj") will result in
graesslin added inline comments.
INLINE COMMENTS
> desktopview.cpp:60
>
> -connect(this, &DesktopView::sceneGraphInitialized, this,
> -[this, corona]() {
> -// check whether the GL Context supports OpenGL
> -// Note: hasOpenGLShaderPrograms is broken, see QTB
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3eb76ed6c126: Only assert on broken GL when we're
rendering using GL (authored by davidedmundson).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8012?vs=1
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8012
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterb
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
set backend. Didn't get an error message
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISIO
