D8159: Add API for setting server decoration palettes

2017-12-07 Thread David Edmundson
davidedmundson abandoned this revision. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8159 To: davidedmundson, #plasma, graesslin Cc: graesslin, broulik, plasma-devel, #frameworks, ZrenBo

D8159: Add API for setting server decoration palettes

2017-11-15 Thread David Edmundson
davidedmundson planned changes to this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8159 To: davidedmundson, #plasma, graesslin Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg

D8159: Add API for setting server decoration palettes

2017-10-27 Thread Martin Flöser
graesslin added a comment. In https://phabricator.kde.org/D8159#160808, @davidedmundson wrote: > FYI, I'm deliberately delaying after I heard from Jonas how they might put it in GTK. > Technically they could have a v1 here, and we could have v2 with the added feature set and it would

D8159: Add API for setting server decoration palettes

2017-10-27 Thread David Edmundson
davidedmundson added a comment. FYI, I'm deliberately delaying after I heard from Jonas how they might put it in GTK. Technically they could have a v1 here, and we could have v2 with the added feature set and it would be fine, but I want to see how the discussion plays out before modifying

D8159: Add API for setting server decoration palettes

2017-10-07 Thread Martin Flöser
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D8159 To: davidedmundson, #plasma, graesslin Cc: graesslin, broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin,

D8159: Add API for setting server decoration palettes

2017-10-06 Thread David Edmundson
davidedmundson added a comment. If it does go into wayland-protocols I imagine it would get renamed? And even if it did get upstreamed and adopted, Steam (for example) would want to set the palette. INLINE COMMENTS > graesslin wrote in server_decoration_interface.h:147 > Nothing better

D8159: Add API for setting server decoration palettes

2017-10-06 Thread Martin Flöser
graesslin added inline comments. INLINE COMMENTS > broulik wrote in server_decoration_interface.h:147 > I think we support both (doing a KService lookup if no complete path given), > imho "name" would also be consistent with what KConfig uses Nothing better than looking into the source: m_co

D8159: Add API for setting server decoration palettes

2017-10-06 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > graesslin wrote in server_decoration_interface.h:147 > is it a paletteName or palettePath? IIRC we set complete paths? I think we support both (doing a KService lookup if no complete path given), imho "name" would also be consistent with what KCo

D8159: Add API for setting server decoration palettes

2017-10-06 Thread Martin Flöser
graesslin added a comment. I'm fine with the change, but when I thought about it, I was wondering whether it would be better to have a dedicated interface. There is at least one other Wayland compositor out there which implements the protocol and I got several requests about upstreaming it.

D8159: Add API for setting server decoration palettes

2017-10-06 Thread David Edmundson
davidedmundson added a comment. In https://phabricator.kde.org/D8159#152648, @broulik wrote: > > This is getting deprecated > > yay... > > global menu also uses it That's next. Will make a new protocol for that, it doesn't fit here. REPOSITORY R127 KWayland REVISION D

D8159: Add API for setting server decoration palettes

2017-10-06 Thread Kai Uwe Broulik
broulik added a comment. > This is getting deprecated yay... global menu also uses it REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8159 To: davidedmundson, #plasma Cc: broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai

D8159: Add API for setting server decoration palettes

2017-10-06 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This is currently handled by the QtExtended surface which is a