This revision was automatically updated to reflect the committed changes.
Closed by commit R845:7f15ce922069: Have a default backend (if one available)
(authored by cryptodude, committed by ivan).
REPOSITORY
R845 Plasma Vault
CHANGES SINCE LAST UPDATE
ivan accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8449
To: cryptodude, ivan, #plasma
Cc: nicolasfella, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg,
ivan added a comment.
I was on a vacation, sorry. I'll test everything today and merge it if I
don't find a problem.
I still don't like the UI change, but lets go with it.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8449
To: cryptodude, ivan, #plasma
ngraham added a comment.
@ivan? I know you had some reservations about the UI, but can we discuss
those and either merge or abandon this?
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8449
To: cryptodude, ivan, #plasma
Cc: nicolasfella, ngraham,
cryptodude added a comment.
> What's the status of this patch?
The status is that I don't have a developer account and am waiting on someone
to merge this.
As this change is practically not doing anything more than making the dialog
react to the distro/packagers, I can't think of a
ngraham added a comment.
What's the status of this patch?
FWIW, @ivan I think the UI change goes quite nicely with the new default.
It's nice and streamlined now.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8449
To: cryptodude, ivan, #plasma
Cc:
nicolasfella added a comment.
https://community.kde.org/Infrastructure/Get_a_Developer_Account
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8449
To: cryptodude, ivan, #plasma
Cc: nicolasfella, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
cryptodude added a comment.
Ok, I see the confusion. The name of this pull request uses the word
'default' and that confused everyone.
What I meant with that is that the User Interface should respond to the
packager picking a default. The UI itself does not pick a default. It just
cryptodude updated this revision to Diff 21302.
cryptodude added a comment.
I tested this version to do what I described.
Please review and/or merge.
The point about EncFS being a security issue when saved on something like a
USB pen is a separate commit I'll create a different
cryptodude added a comment.
In https://phabricator.kde.org/D8449#159406, @ivan wrote:
> Having a default backend (IMO) has nothing to do with the UI.
I'm not sure what else it would have an effect on. Default to me means its
just a suggested one and users can still override it.
ivan added a comment.
p.s.
> Do I need to relogin to make a kded module show up?
No. You can just `kquitapp5 kded5; kded5` to restart it.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8449
To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel,
ivan added a comment.
Having a default backend (IMO) has nothing to do with the UI. What is the
rationale behind changing a combo-box (a widget designed for multiple choice
questions) to a button?
As far as CryFS vs EncFS - yes, CryFS is designed to avoid all the problems
that EncFS
ngraham added a comment.
That sounds good to me, but yeah, since these differences are super-technical
and not really relevant to most users, I think that regardless of our
messaging, a good default is important here if multiple backends are available.
Based on what you've written, it looks
cryptodude added a comment.
In https://phabricator.kde.org/D8449#159337, @ngraham wrote:
> I don't think choosing a random backend makes sense without at least some
information provided to the user. How about adding a text view below the
combobox showing a quick human-friendly summary
cryptodude edited the summary of this revision.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8449
To: cryptodude, ivan, #plasma
Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
ngraham added a comment.
I don't think choosing a random backend makes sense without at least some
information provided to the user. How about adding a text view below the
combobox showing a quick human-friendly summary of the purported advantage of
each backend? like this:
"EncFS is
ngraham added reviewers: ivan, Plasma.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D8449
To: cryptodude, ivan, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
cryptodude created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The creation of a new vault uses a wizard.
The first page of the wizard currently shows a combobox with 2 backends, with
one
18 matches
Mail list logo
