ngraham added a comment.
This came up again recently as a user pain point:
https://www.reddit.com/r/kde/comments/7vnxhc/plasma_512_is_out_and_it_is_faster_stabler_and/dttyqwi/?utm_content=permalink_medium=front_source=reddit_name=kde
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
hein added a comment.
Sorry Emirald.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel, #plasma, #vdg
Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts,
emateli abandoned this revision.
emateli added a comment.
Closing this since we're unable to reach a consensus. None of the proposed
changes are how I envision the patch to work.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel,
ngraham added a reviewer: VDG.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel, #plasma, #vdg
Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
ngraham added a comment.
We discussed the matter in the VDG Telegram room this morning and came up
with some alternative ideas:
- Ignore drag operations that fall below a certain threshold, to only allow
clear and purposeful drags and filter out accidental drags caused by imprecise
emateli added a comment.
In https://phabricator.kde.org/D8564#179707, @ngraham wrote:
> I found at least one user during my triaging of Task Manager bug who was
sufficiently motivated to file a bug that this would resolve:
https://bugs.kde.org/show_bug.cgi?id=361984
I don't
ngraham added a comment.
I found at least one user during my triaging of Task Manager bug who was
sufficiently motivated to file a bug that this would resolve:
https://bugs.kde.org/show_bug.cgi?id=361984
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
ngraham edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel, #plasma
Cc: ngraham, davidedmundson, romangg, hein, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts,
ngraham added a comment.
I think the question we need to ask ourselves is whether the ability to
create .desktop shortcuts by dragging from the task manager is useful to
enough people to outweigh the confusion and frustration to other people caused
by unwanted drags.
As a compromise,
emateli added a comment.
> To be honest - dropping the patch.
I feel as that's the easy part.
> Sure. The URL to the .desktop file is the exchange-ready representation for
an app, which the task item is a delegate for. I don't see a good reason not to
be able to drag one,
hein added a comment.
> What would you propose?
To be honest - dropping the patch.
> But is the dragging around into external applications of .desktop files a
feature that we want?
Sure. The URL to the .desktop file is the exchange-ready representation for
an app, which the
ngraham added a comment.
FWIW, I do approve of the goal here. I can't imagine that any more than a
very very tiny fraction of all drags to the desktop or into a web browser or
text editor window are intentional.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
emateli added a comment.
> Task Manager items are not widgets, it's content, and the widget mutability
state should not affect content drags.
I don't see why it can't. Task manager items can be aware of the panel state
if that's needed.
> "If widgets are locked, stop adding a
subdiff added a comment.
In https://phabricator.kde.org/D8564#162797, @emateli wrote:
> I feel like the long press can mess with the manual ordering of task
manager icons.
**Short press**
Press -> start timer
release -> single click on task
timer stops
Press ->
davidedmundson added a comment.
Sounds like we want what is something similar to
https://phabricator.kde.org/R296:86bbebdee213f08ae615d7459304cbd17f6b7d7d in
kdeclarative's DragArea
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli,
emateli added a comment.
I feel like the long press can mess with the manual ordering of task manager
icons.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel, #plasma
Cc: subdiff, hein, plasma-devel, ZrenBot, progwolff,
subdiff added a comment.
That said accidental drags from the task manager are really a common issue.
Could we do some sort of double-tap-and-drag instead of just drag to minimize
the risk for an accidental drag?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
hein added a comment.
I still don't like it, sorry - the patch also feels technically and
semantically wrong to me. "If widgets are locked, stop adding a certain kind of
data to the drag" is a pretty bad hack.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
emateli added a comment.
Hi @hein, thanks for your input and I understand that this might break some
functionality that I'm unaware of (such as the drop of task manager icons into
the pager widget).
The current revision allows drop into the pager widget and other plasma
widgets(needs
emateli updated this revision to Diff 21689.
emateli added a comment.
Remove empty line
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8564?vs=21688=21689
BRANCH
disable-drop
REVISION DETAIL
https://phabricator.kde.org/D8564
AFFECTED FILES
emateli updated this revision to Diff 21688.
emateli added a comment.
Allow task items to be dropped onto other widgets
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8564?vs=21606=21688
BRANCH
disable-drop
REVISION DETAIL
hein added a comment.
As-is I would not accept this patch, I'm sorry. Task Manager items are not
widgets, it's content, and the widget mutability state should not affect
content drags.
This particular drag is used for workspace features some people do rely on,
e.g.:
- moving a
emateli added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
emateli added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
emateli retitled this revision from "Disallow drop of task manager widgets
outside of plasmoid when locked" to "Disallow drop of task manager icons
outside of plasmoid when widgets are locked".
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli,
25 matches
Mail list logo
